Configure log4net from embedded resource log4net.xml in tests #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
changed the title
bahusoid
changed the title
bahusoid
changed the title
fredericDelaporte
approved these changes
Apr 12, 2020
georgi-yakimov
pushed a commit
to georgi-yakimov/nhibernate-core
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use the same configuration from both .NET Core and full .NET Framework
Moved log4net configuration to TestContext to make sure that log4net is properly configured even for tests not based on TestCase and get rid of all additional Configure calls (attribute configuration is also removed as not reliable and not needed anymore)